Generalize modern table presentation with application to Protection #3770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansOlsson
reviewed
Nov 12, 2025
|
|
||
| \begin{annotationdefinition*}[access]\label{modelica:Protection.access}\annotationindex{access}\index{Protection@\robustinline{Protection}!\robustinline{access} sub-annotation} | ||
| \begin{synopsis}\begin{lstlisting} | ||
| /*literal*/ constant Access Protection.access; |
Collaborator
There was a problem hiding this comment.
Suggested change
| /*literal*/ constant Access Protection.access; | |
| /*literal*/ constant Access access; |
Making it consistent with the other ones.
Collaborator
Author
There was a problem hiding this comment.
You are right that the PR is currently inconsistent and that this needs to be fixed.
However, I am not sure it's such a good idea to present the sub-annotations in the same way as the annotations residing directly under annotation(…).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make the presentation of the
Protectionannotation more similar to the presentation of other annotations, even thoughProtectiononly acts as a container for sub-annotations which are defined in more detail one by one. If we can work this out forProtection, it should be straightforward to treatDocumentationin the same manner.